[PWGCF] New task for FT0 di-hadron correlation with the main focus on Nch dependence#15852
Merged
wenyaCern merged 2 commits intoAliceO2Group:masterfrom Apr 23, 2026
Merged
[PWGCF] New task for FT0 di-hadron correlation with the main focus on Nch dependence#15852wenyaCern merged 2 commits intoAliceO2Group:masterfrom
wenyaCern merged 2 commits intoAliceO2Group:masterfrom
Conversation
|
O2 linter results: ❌ 1 errors, |
github-actions
Bot
changed the title
Contributor
Author
|
From what I can see of the errors from the O2 linter is from old code names in the cmake list. |
Thorkj
requested review from
alibuild,
jaelpark,
otonvd,
shouqiye,
victor-gonzalez and
wenyaCern
as code owners
Collaborator
|
Dear @Thorkj |
Contributor
Author
|
Dear @wenyaCern, |
wenyaCern
approved these changes
Apr 23, 2026
| PUBLIC_LINK_LIBRARIES O2Physics::AnalysisCore | ||
| COMPONENT_NAME Analysis) | ||
|
|
||
| o2physics_add_dpl_workflow(lambdacorr |
Collaborator
There was a problem hiding this comment.
Dear @Thorkj
Could you please modify the name as the introduction from O2-linter? It would be better if you use the camelCase for the name
smaff92
pushed a commit
to smaff92/O2Physics
that referenced
this pull request
Apr 27, 2026
vkucera
reviewed
Apr 27, 2026
| HistogramRegistry registry{"registry"}; | ||
|
|
||
| // define global variables | ||
| TRandom3* gRandom = new TRandom3(); |
| kFT0COuterRingMax = 207 | ||
| }; | ||
|
|
||
| std::array<std::array<int, 1>, 16> eventCuts; |
| { | ||
|
|
||
| const AxisSpec axisPhi{72, 0.0, constants::math::TwoPI, "#varphi"}; | ||
| const AxisSpec axisEta{40, -1., 1., "#eta"}; |
Collaborator
There was a problem hiding this comment.
This shadows the configurable.
Comment on lines
+139
to
+142
| std::vector<double> multT0CCutPars; | ||
| std::vector<double> multPVT0CCutPars; | ||
| std::vector<double> multGlobalPVCutPars; | ||
| std::vector<double> multMultV0ACutPars; |
| if (mEfficiency == nullptr) { | ||
| LOGF(fatal, "Could not load efficiency histogram for trigger particles from %s", cfgEfficiency.value.c_str()); | ||
| } | ||
| LOGF(info, "Loaded efficiency histogram from %s (%p)", cfgEfficiency.value.c_str(), (void*)mEfficiency); |
Collaborator
There was a problem hiding this comment.
What are you trying to achieve with the void* cast?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.